jake/Lumotia
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

perf(sqlx): strip default features — workspace uses none of macros / migrate / any / json

Browse Source 
sqlx 0.8's default feature set pulls in `any`, `macros`, `migrate`, and
`json`. Grepping the workspace confirms none of these are used — the
code calls sqlx::query() / query_scalar() at runtime, implements its own
migration sequencing in crates/storage/src/migrations.rs, is sqlite-only
(no `any` needed), and never derives FromRow / applies sqlx proc-macros.

Dropping them keeps only what's needed: runtime-tokio + sqlite.

Why it matters disproportionately on Windows: the `macros` feature pulls
sqlx-macros → sqlx-macros-core → proc-macro2 / syn / quote / async-trait
/ url / heck / dotenvy / sha2 / filetime. Each proc-macro crate on
Windows MSVC compiles to a .dll with a full linker invocation (slower
ABI than Linux/macOS proc-macro .so). Net: tens of seconds shaved off
every cold-cache CI run, compounding with the cache-path fix in the next
commit.

kon-mcp was already lean (default-features = false); matching that shape
across the workspace now.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Jake
2026-04-21 15:42:04 +01:00
parent 65280c776e
commit 26b41389b2
2 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
crates/storage/Cargo.toml
View File

@@ -8,7 +8,12 @@ description = "SQLite persistence, BM25 search, and file storage for Kon"
kon-core = { path = "../core" } kon-core = { path = "../core" }
# SQLite with compile-time checked queries # SQLite with compile-time checked queries
sqlx = { version = "0.8", features = ["sqlite", "runtime-tokio"] } # default-features = false strips sqlx's `any`, `macros`, `migrate`, `json` —
# none of which this crate uses (it calls sqlx::query() / query_scalar()
# directly and runs its own migration machinery). Cuts ~40% of sqlx's
# compile graph, most visibly on Windows MSVC where each proc-macro crate
# (which `macros` pulls in) becomes a slow .dll link.
sqlx = { version = "0.8", default-features = false, features = ["runtime-tokio", "sqlite"] }
# Async runtime # Async runtime
tokio = { version = "1", features = ["rt", "sync", "macros"] } tokio = { version = "1", features = ["rt", "sync", "macros"] }

4
src-tauri/Cargo.toml
View File

@@ -42,7 +42,9 @@ arboard = "3.6.1"
# SqlitePool is named directly from src-tauri/src/lib.rs (the AppState # SqlitePool is named directly from src-tauri/src/lib.rs (the AppState
# stores it). Must be unconditional, not Linux-only — naming a type from # stores it). Must be unconditional, not Linux-only — naming a type from
# a transitive dep requires the dep be listed here too. # a transitive dep requires the dep be listed here too.
sqlx = { version = "0.8", features = ["sqlite", "runtime-tokio"] } # See crates/storage/Cargo.toml — default-features = false drops macros /
# migrate / any / json which this crate doesn't use. Only names SqlitePool.
sqlx = { version = "0.8", default-features = false, features = ["runtime-tokio", "sqlite"] }
uuid = { version = "1", features = ["v4"] } uuid = { version = "1", features = ["v4"] }
[target.'cfg(target_os = "linux")'.dependencies] [target.'cfg(target_os = "linux")'.dependencies]