fix(ui): impeccable detect — perf + taste touch-ups across four components

Mechanical fixes from `npx impeccable detect`:

- Sidebar.svelte: replace `transition: width, min-width` on the aside
  with a wrapping CSS-grid container animating `grid-template-columns`.
  Avoids per-frame layout cost from animating `width` directly.
- MorningTriageModal.svelte: swap pure `bg-black/50` overlay for the
  brand deep-neutral `rgba(26, 24, 22, 0.5)` (#1a1816 @ 50%). TODO left
  in source to promote this to a `--color-overlay` token in app.css.
- Toggle.svelte: drop bouncy `cubic-bezier(0.34, 1.56, 0.64, 1)`
  (1.56 overshoot) for ease-out-quart `cubic-bezier(0.16, 1, 0.3, 1)`.
  Still snappy, no overshoot — better fit for a toggle.
- TasksPage.svelte: same grid-template-columns refactor as Sidebar
  for the list-sidebar `transition: width` declaration.

Verification:
- npm run check: 1 pre-existing error (vite.config.js:5), 1 unrelated
  warning in SettingsGroup (out of scope, owned by parallel subagent).
- npm run build: clean.
- cargo clippy --all-targets -- -D warnings: clean (with LIBCLANG_PATH).
- cargo test --workspace: 283 passed, 0 failed.
- cargo fmt --check: pre-existing diffs in main.rs / lib.rs (no Rust
  files were touched in this commit).

Manual smoke deferred — `npm run dev` is in use by the SettingsPage
subagent, so the build-clean signal is the proxy.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-04-29 12:48:14 +01:00
parent 22d554e85b
commit 6469663c25
4 changed files with 36 additions and 9 deletions

View File

@@ -28,10 +28,20 @@
} }
</script> </script>
<!--
Layout-transition perf fix: previously animated `width` + `min-width` which
triggers layout on every frame. Replaced with a CSS-grid track-size
transition (`grid-template-columns`) on a wrapping container; the inner
flex column lives in the single track. This keeps the parent flex row in
charge of width allocation but moves the animated property onto a track
spec, which the browser can collapse without re-running our layout work.
-->
<div
class="grid h-full {collapsed ? 'grid-cols-[48px]' : 'grid-cols-[210px]'}"
style="transition: grid-template-columns var(--duration-ui)"
>
<aside <aside
class="flex flex-col bg-sidebar border-r border-border-subtle h-full overflow-hidden class="flex flex-col bg-sidebar border-r border-border-subtle h-full overflow-hidden min-w-0"
{collapsed ? 'w-[48px] min-w-[48px]' : 'w-[210px] min-w-[210px]'}"
style="transition: width var(--duration-ui), min-width var(--duration-ui)"
> >
<!-- Logo + toggle --> <!-- Logo + toggle -->
<div class="flex items-center {collapsed ? 'justify-center px-0 pt-4 pb-1' : 'px-5 pt-4 pb-1'} relative"> <div class="flex items-center {collapsed ? 'justify-center px-0 pt-4 pb-1' : 'px-5 pt-4 pb-1'} relative">
@@ -165,3 +175,4 @@
</div> </div>
{/if} {/if}
</aside> </aside>
</div>

View File

@@ -257,9 +257,15 @@
<svelte:window onkeydown={handleKeydown} /> <svelte:window onkeydown={handleKeydown} />
{#if open} {#if open}
<!--
Pure-black-white taste fix: replaced `bg-black/50` overlay with the brand
deep-neutral `#1a1816` at 50% alpha. TODO: promote this colour to a
`--color-overlay` token in app.css so the value isn't inlined per-modal.
-->
<div <div
bind:this={dialogEl} bind:this={dialogEl}
class="fixed inset-0 z-50 flex items-center justify-center bg-black/50 backdrop-blur-sm animate-fade-in" class="fixed inset-0 z-50 flex items-center justify-center backdrop-blur-sm animate-fade-in"
style="background: rgba(26, 24, 22, 0.5)"
role="dialog" role="dialog"
aria-modal="true" aria-modal="true"
aria-labelledby="triage-title" aria-labelledby="triage-title"

View File

@@ -15,9 +15,9 @@
> >
<span <span
class="absolute top-[3px] left-[3px] w-4 h-4 rounded-full bg-white shadow-sm class="absolute top-[3px] left-[3px] w-4 h-4 rounded-full bg-white shadow-sm
ease-[cubic-bezier(0.34,1.56,0.64,1)] ease-[cubic-bezier(0.16,1,0.3,1)]
{checked ? 'translate-x-[16px]' : 'translate-x-0'}" {checked ? 'translate-x-[16px]' : 'translate-x-0'}"
style="transition: transform var(--duration-ui) cubic-bezier(0.34, 1.56, 0.64, 1)" style="transition: transform var(--duration-ui) cubic-bezier(0.16, 1, 0.3, 1)"
></span> ></span>
</button> </button>
<div class="flex-1 min-w-0"> <div class="flex-1 min-w-0">

View File

@@ -458,11 +458,20 @@
<!-- Main content: sidebar + tasks --> <!-- Main content: sidebar + tasks -->
<div class="flex flex-1 min-h-0 px-7 pb-4 gap-3"> <div class="flex flex-1 min-h-0 px-7 pb-4 gap-3">
<!--
Layout-transition perf fix: was animating `width` directly. Now wraps
the list sidebar in a CSS-grid container whose `grid-template-columns`
track-size transitions between collapsed/expanded widths. Same visual
effect, single transitioning property the browser can handle as a
track-spec change rather than a width re-flow each frame.
-->
<!-- List sidebar --> <!-- List sidebar -->
<div <div
class="flex flex-col bg-bg-elevated rounded-2xl border border-border-subtle overflow-hidden class="grid {sidebarCollapsed ? 'grid-cols-[40px]' : 'grid-cols-[160px]'}"
{sidebarCollapsed ? 'w-[40px] min-w-[40px]' : 'w-[160px] min-w-[160px]'}" style="transition: grid-template-columns var(--duration-ui)"
style="transition: width var(--duration-ui)" >
<div
class="flex flex-col bg-bg-elevated rounded-2xl border border-border-subtle overflow-hidden min-w-0"
> >
<!-- Collapse toggle --> <!-- Collapse toggle -->
<button <button
@@ -561,6 +570,7 @@
</div> </div>
{/if} {/if}
</div> </div>
</div>
<!-- Task list --> <!-- Task list -->
<div class="flex-1 overflow-y-auto min-h-0"> <div class="flex-1 overflow-y-auto min-h-0">