-
agent: lumotia-rebrand — fix Codex cross-model review blockers
released this
2026-05-13 12:39:21 +00:00 Codex independent review found 11 blockers post-cascade. All addressed.
CRITICAL (data-loss / crash):
-
crates/core/src/paths.rs — migrate_legacy_data_dir_inner used
fs::rename which fails with EXDEV when source + target are on
different filesystems (encrypted-home, bind mounts, separate
$XDG_DATA_HOME partition). Combined with the Phase 5 QC fix that
made migration errors fatal, this would crash on first launch
for any user whose data dir spans filesystems. Added
rename_or_copy_tree() that falls back to copy_dir_recursive +
remove_dir_all on CrossesDevices / errno 18 (EXDEV). Symlinks
preserved verbatim. Same fallback applied to magnotia.db ->
lumotia.db inside the dir. -
Added 4 unit tests: copy_dir_recursive preserves nested
structure, rename_or_copy_tree same-filesystem happy path,
is_cross_device classifies CrossesDevices kind + raw errno 18.
Doc residuals (blockers 1-9):
- crates/cloud-providers/Cargo.toml — "Wyrdnote pending rebrand"
description. - crates/cloud-providers/src/provider.rs — module docs + test
fixture Wyrdnote refs. - crates/transcription/src/orchestrator.rs — module docs + test
fixture Wyrdnote refs. - docs/roadmap/2026-05-10-pkm-phase-tooling-shortlist.md — phase
name + outputs/wyrdnote path refs. - docs/architecture-map/04-llm-formatting-mcp/llm-tests.md —
MAGNOTIA_LLM_TEST_MODEL env var. - .../cloud-providers-stubs.md — MAGNOTIA_API_KEY_*.
- docs/architecture-map/03-audio-transcription/tests-and-fixtures.md
— MAGNOTIA_WHISPER_*. - docs/gpu-tuning/plan.md — MAGNOTIA_BENCH_RUN.
- docs/superpowers/specs/2026-05-09-battery-gpu-aware-thread-tuning-
design.md + corresponding plan — MAGNOTIA_POWER_STATE_OVERRIDE,
MAGNOTIA_INFERENCE_THREADS.
cargo test --workspace: 343 pass / 0 fail (up from 339; +4 EXDEV
fallback tests).Co-Authored-By: Claude Opus 4.7 (1M context) noreply@anthropic.com
Downloads
-