Files

Claude 89c63891fa chore: rebrand from Kon/Corbie to Magnotia

Replace all instances of the legacy product names "Kon" and "Corbie" with
"Magnotia" across user-facing copy, code identifiers, package names, bundle
ids, file paths, and documentation. Preserves the unrelated "konsole" (KDE
terminal) reference and the parent CORBEL company name.

- Renames 10 Rust crates (kon-* → magnotia-*) and the tauri binary
- Updates package.json, tauri.conf.json (productName + identifier)
- Renames CSS classes (kon-rh-* → magnotia-rh-*) and animations
- Renames brand and roadmap docs
- Regenerates Cargo.lock and package-lock.json

Verified: svelte-check passes; pure-rust crates compile under new names.

2026-04-30 13:06:55 +00:00

2.0 KiB

Raw Blame History

RB-12 MAJOR: hotkey device filtering hard-codes KEY_A / KEY_R

Severity: MAJOR Path: crates/hotkey/src/linux.rs:236-241 Source: 2026-04-22 code review Labels: release-blocker, major, hotkey, correctness Status: RESOLVED (2026-04-22)

Resolution

Extracted device_supports_combo(supported, combo) -> bool as a pure helper. try_attach_device now snapshots the current HotkeyCombo from hotkey_rx (returning early with false if the listener is unconfigured) and uses the helper to filter devices by the configured trigger key.

Tests in crates/hotkey/src/linux.rs (linux::tests):

attaches_when_device_supports_configured_trigger
rejects_when_device_lacks_configured_trigger
rejects_when_device_reports_no_keys
attaches_for_non_a_non_r_trigger (direct regression)

Manual verification of the Ctrl+Shift+D binding in Settings remains on the ship-gate checklist — code path is correct; runtime GUI check is deferred.

Problem

try_attach_device claims to check whether an input device supports the configured hotkey's key, but the implementation tests for hard-coded KEY_A or KEY_R instead of consulting the actual HotkeyCombo that was configured. Hotkeys bound to any other key (which is most of them) can be silently skipped even when the device supports them.

This is a correctness bug in a user-facing feature. A user who binds Magnotia to Ctrl+Shift+D and sees "no hotkey fires" has no obvious path to diagnose it.

Acceptance

Device attachment consults the actual configured HotkeyCombo.trigger key code.
Regression test: try_attach_device called with a mock device that supports KEY_D attaches when the configured hotkey's trigger is D, does not attach when the trigger is a key the device doesn't support.
Manual verification: bind Ctrl+Shift+D in Settings, confirm it fires in a running Magnotia.

Fix scope

Small. Replace the hard-coded constants with a lookup from the passed-in HotkeyCombo.

Dependencies

None — standalone fix.

2.0 KiB Raw Blame History