Files

Jake 528facfab0 fix(rb-12): hotkey device filter consults configured HotkeyCombo

try_attach_device was rejecting any device that did not report KEY_A or
KEY_R — a leftover heuristic from the whisper-overlay seed. A user whose
binding was anything else (Ctrl+Shift+D is a common default) would see
no hotkey events from that device even though it supports the key.

Replace the hard-coded check with device_supports_combo(supported,
combo), a pure helper that reads the configured trigger key code from
the HotkeyCombo snapshot. Snapshot is taken from hotkey_rx.borrow()
before opening the device; an unconfigured or shutting-down listener
short-circuits to a non-attach.

Four regression tests in linux::tests cover: supported+D → attach,
unsupported → reject, no reported keys → reject, and the explicit
non-A/non-R case that demonstrates the bug.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-04-22 10:18:54 +01:00

3.0 KiB

Raw Blame History

name, description, type, tags

name

description

type

Release-blockers

Issues here must land before Kon v0.1 ships. Each is sourced from docs/code-review-2026-04-22.md. When gh CLI is available, these should be mirrored as real GitHub issues on jakejars/kon.

CRITICAL (3)

#	File	Area	Fix scope
RB-01	c1-live-session-race.md	`src-tauri/commands/live.rs`	large
RB-02	c3-migrations-atomicity.md	`crates/storage/migrations.rs`	medium
RB-03	c4-transcript-profile-fk.md	`crates/storage/migrations.rs` + `database.rs`	large

MAJOR (8 open, 1 resolved)

#	File	Area	Fix scope
RB-04	run-live-session-monolith.md	`src-tauri/commands/live.rs`	large
RB-05	poll-inference-channel-fatality.md	`src-tauri/commands/live.rs`	medium
RB-06	native-capture-worker-join.md	`src-tauri/commands/audio.rs`	medium
RB-07	runtime-capabilities-accelerators.md	`src-tauri/commands/models.rs`	medium
RB-08	power-assertion-macos-objc2.md	`src-tauri/commands/power.rs`	medium
RB-09	decoder-partial-audio-on-error.md	`crates/audio/decode.rs`	medium
RB-10	llm-prompt-preflight.md	`crates/llm/lib.rs`	medium
RB-11	keystore-thread-safety.md	`crates/cloud-providers/keystore.rs`	medium

Resolved

#	File	Area	Resolution
RB-12	hotkey-linux-device-filter.md	`crates/hotkey/linux.rs`	Extracted `device_supports_combo` helper; `try_attach_device` now reads the configured `HotkeyCombo` from the watch channel and checks support for that trigger key. Four regression tests land in `linux::tests`.

Dependencies

RB-01 (live session race)
  └── blocked by RB-04 (run_live_session monolith refactor)

RB-03 (transcript-profile FK)
  └── coupled with RB-02 (migrations atomicity)
      — a v9 migration adding the FK constraint must be transactional

How to convert to GitHub issues

Once gh CLI is installed and authed (sudo dnf install -y gh && gh auth login):

for file in docs/issues/rb-*.md c1-*.md c3-*.md c4-*.md run-*.md poll-*.md \
            native-*.md runtime-*.md power-*.md decoder-*.md llm-*.md \
            keystore-*.md hotkey-*.md
  set -l title (head -1 "$file" | sed 's/^# //')
  gh issue create --repo jakejars/kon --title "$title" --body-file "$file" \
      --label release-blocker
end

Issue labels to create first (gh label create):

release-blocker — colour #d73a4a
critical — colour #b60205
major — colour #d93f0b

3.0 KiB Raw Blame History