Files
Lumotia/docs/issues
Jake 54d9adf1f0 fix(rb-07): runtime capabilities derive accelerators honestly
get_runtime_capabilities was returning `accelerators = ["cpu",
"vulkan"]` and `whisper.supports_gpu = true` regardless of build
config or runtime state. On a macOS build it falsely advertised
"vulkan" (the backend actually resolves via MoltenVK as Metal); on a
whisper-disabled build it claimed GPU support for an engine that
hadn't been linked.

Added `compose_accelerators(whisper_enabled, loader_available, target)`
— a pure helper that always emits "cpu" first and appends the
platform-appropriate GPU name only when whisper is compiled in AND the
Vulkan loader resolves. `supported_accelerators()` wraps it with the
live `cfg!(feature = "whisper")`, loader probe, and target OS.

`get_runtime_capabilities` now calls `supported_accelerators()` and
sets `whisper.supports_gpu = cfg!(feature = "whisper")`. Parakeet
stays CPU-only.

Five tests in `commands::models::tests` cover the permutation matrix:
whisper on/off, loader present/missing, macOS vs other. Both feature
configurations (`--features whisper` and `--no-default-features`)
build and pass tests.

Macos Metal-loader resolution on real hardware stays on the
ship-gate checklist — the detection logic is verifiable from Linux
but runtime behaviour is not.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-22 10:32:04 +01:00
..

name, description, type, tags
name description type tags
Release-blockers index Open issues that must land before v0.1 ships, derived from the 2026-04-22 code review index
issues
release-blockers

Release-blockers

Issues here must land before Kon v0.1 ships. Each is sourced from docs/code-review-2026-04-22.md. When gh CLI is available, these should be mirrored as real GitHub issues on jakejars/kon.

CRITICAL (2 open, 1 resolved)

# File Area Fix scope
RB-01 c1-live-session-race.md src-tauri/commands/live.rs large
RB-03 c4-transcript-profile-fk.md crates/storage/migrations.rs + database.rs large

MAJOR (6 open, 3 resolved)

# File Area Fix scope
RB-04 run-live-session-monolith.md src-tauri/commands/live.rs large
RB-05 poll-inference-channel-fatality.md src-tauri/commands/live.rs medium
RB-06 native-capture-worker-join.md src-tauri/commands/audio.rs medium
RB-08 power-assertion-macos-objc2.md src-tauri/commands/power.rs medium
RB-10 llm-prompt-preflight.md crates/llm/lib.rs medium
RB-11 keystore-thread-safety.md crates/cloud-providers/keystore.rs medium

Resolved

# File Area Resolution
RB-02 c3-migrations-atomicity.md crates/storage/migrations.rs Each migration now runs inside a pool.begin() / tx.commit() transaction alongside its schema_version insert. Regression test injects a poisoned v9 migration and asserts neither the partial schema change nor the version row persists. DRY'd run_migrations_up_to test helper onto the same code path.
RB-07 runtime-capabilities-accelerators.md src-tauri/commands/models.rs Introduced compose_accelerators(whisper_enabled, loader_available, target) as a pure helper; supported_accelerators() reads cfg(feature = "whisper"), vulkan_loader_available(), and target OS then delegates. get_runtime_capabilities uses it in place of the hard-coded ["cpu", "vulkan"]. Whisper's supports_gpu now follows the feature flag. Five regression tests cover all permutations.
RB-09 decoder-partial-audio-on-error.md crates/audio/decode.rs Packet-loop now propagates all non-EOF SymphoniaErrors as AudioDecodeFailed; per-packet decode errors bubble via ?. Mock-MediaSource regression test confirms mid-stream I/O errors surface instead of returning partial audio.
RB-12 hotkey-linux-device-filter.md crates/hotkey/linux.rs Extracted device_supports_combo helper; try_attach_device now reads the configured HotkeyCombo from the watch channel and checks support for that trigger key. Four regression tests land in linux::tests.

Dependencies

RB-01 (live session race)
  └── blocked by RB-04 (run_live_session monolith refactor)

RB-03 (transcript-profile FK)
  └── coupled with RB-02 (migrations atomicity)
      — a v9 migration adding the FK constraint must be transactional

How to convert to GitHub issues

Once gh CLI is installed and authed (sudo dnf install -y gh && gh auth login):

for file in docs/issues/rb-*.md c1-*.md c3-*.md c4-*.md run-*.md poll-*.md \
            native-*.md runtime-*.md power-*.md decoder-*.md llm-*.md \
            keystore-*.md hotkey-*.md
  set -l title (head -1 "$file" | sed 's/^# //')
  gh issue create --repo jakejars/kon --title "$title" --body-file "$file" \
      --label release-blocker
end

Issue labels to create first (gh label create):

  • release-blocker — colour #d73a4a
  • critical — colour #b60205
  • major — colour #d93f0b