Files
Lumotia/docs/issues
Jake 9b0067b4c0
Some checks failed
check / cargo check (macos-latest) (push) Has been cancelled
check / cargo check (ubuntu-22.04) (push) Has been cancelled
check / cargo check (windows-latest) (push) Has been cancelled
check / svelte build + lint (push) Has been cancelled
Land release blocker fixes and workspace cleanup
2026-04-23 00:16:09 +01:00
..

name, description, type, tags
name description type tags
Release-blockers index Open issues that must land before v0.1 ships, derived from the 2026-04-22 code review index
issues
release-blockers

Release-blockers

Issues here must land before Kon v0.1 ships. Each is sourced from docs/code-review-2026-04-22.md. When gh CLI is available, these should be mirrored as real GitHub issues on jakejars/kon.

CRITICAL (0 open, 3 resolved)

No open CRITICAL blockers.

MAJOR (1 open, 8 resolved)

# File Area Fix scope
RB-08 power-assertion-macos-objc2.md src-tauri/commands/power.rs medium

Resolved

# File Area Resolution
RB-01 c1-live-session-race.md src-tauri/commands/live.rs Added LiveTranscriptionState.lifecycle: tokio::sync::Mutex<()> and hold it across the async spans of both start_live_transcription_session and stop_live_transcription_session. The running-slot check/insert and stop/take/join sequence are now serialized, so concurrent starts can no longer both pass the empty-slot check and a start during stop blocks until the previous worker fully joins. Two async regression tests cover both races.
RB-02 c3-migrations-atomicity.md crates/storage/migrations.rs Each migration now runs inside a pool.begin() / tx.commit() transaction alongside its schema_version insert. Regression test injects a poisoned v9 migration and asserts neither the partial schema change nor the version row persists. DRY'd run_migrations_up_to test helper onto the same code path.
RB-03 c4-transcript-profile-fk.md crates/storage/migrations.rs + database.rs Added a transactional v9 rebuild of transcripts that enforces profile_id REFERENCES profiles(id) ON DELETE RESTRICT, reassigns any orphaned transcript provenance to DEFAULT_PROFILE_ID, rebuilds dependent segments / FTS state, and preserves valid profile references. insert_transcript now rejects unknown profile ids up front, and delete_profile returns a clear reassign-first error when transcripts still reference the profile. Regression tests cover migration reconciliation, invalid inserts, and delete rejection.
RB-04 run-live-session-monolith.md src-tauri/commands/live.rs Replaced the 200+ line run_live_session loop with an explicit LiveSessionRuntime + LiveLoopState structure. Capture startup, runtime mic-error draining, audio chunk processing, overflow handling, stop-tail flush, inference dispatch/drain, and WAV finalisation each live in focused helpers, preserving behaviour while making the lifecycle auditable enough for RB-01 follow-up. Existing live tests and the full kon lib suite stay green.
RB-05 poll-inference-channel-fatality.md src-tauri/commands/live.rs poll_inference now treats result-channel loss as a listener-lifecycle problem rather than a transcription failure. On the first result_channel.send(...) error it marks the live result listener as lost, emits a single warning that transcription will continue in the background, and keeps processing later chunks without retrying the dead channel. Regression test simulates a dead result listener and asserts chunk processing continues with only one warning.
RB-06 native-capture-worker-join.md src-tauri/commands/audio.rs NativeCaptureState.stop_tx replaced by worker: AsyncMutex<Option<CaptureWorker>>. CaptureWorker bundles the stop sender and the spawned task's JoinHandle; stop_worker(worker) sends stop then awaits termination. Both start_native_capture (prior-worker stop) and stop_native_capture use the helper. Removed the 50ms sleep — the join barrier is exact. Two regression tests cover the lifecycle guarantee and the already-exited case.
RB-07 runtime-capabilities-accelerators.md src-tauri/commands/models.rs Introduced compose_accelerators(whisper_enabled, loader_available, target) as a pure helper; supported_accelerators() reads cfg(feature = "whisper"), vulkan_loader_available(), and target OS then delegates. get_runtime_capabilities uses it in place of the hard-coded ["cpu", "vulkan"]. Whisper's supports_gpu now follows the feature flag. Five regression tests cover all permutations.
RB-09 decoder-partial-audio-on-error.md crates/audio/decode.rs Packet-loop now propagates all non-EOF SymphoniaErrors as AudioDecodeFailed; per-packet decode errors bubble via ?. Mock-MediaSource regression test confirms mid-stream I/O errors surface instead of returning partial audio.
RB-10 llm-prompt-preflight.md crates/llm/lib.rs Added an explicit prompt-budget preflight before context creation. If prompt_tokens + max_tokens + reserve exceeds the 8192-token cap, generate now returns a typed EngineError::PromptTooLong { ... } instead of failing late inside inference. Regression tests cover both the over-budget and exact-budget boundaries.
RB-11 keystore-thread-safety.md crates/cloud-providers/keystore.rs Replaced the std::env::set_var stub with a process-global OnceLock<Mutex<HashMap<...>>> keystore, keeping the API safe from any thread. Retrieval still falls back to read-only KON_API_KEY_* env vars for externally supplied secrets. Two regression tests cover store/retrieve and provider isolation.
RB-12 hotkey-linux-device-filter.md crates/hotkey/linux.rs Extracted device_supports_combo helper; try_attach_device now reads the configured HotkeyCombo from the watch channel and checks support for that trigger key. Four regression tests land in linux::tests.

Remaining blocker

RB-08 remains open pending manual runtime verification on a real macOS machine (pmset -g assertions, background live-session sanity check).

How to convert to GitHub issues

Once gh CLI is installed and authed (sudo dnf install -y gh && gh auth login):

for file in docs/issues/rb-*.md c1-*.md c3-*.md c4-*.md run-*.md poll-*.md \
            native-*.md runtime-*.md power-*.md decoder-*.md llm-*.md \
            keystore-*.md hotkey-*.md
  set -l title (head -1 "$file" | sed 's/^# //')
  gh issue create --repo jakejars/kon --title "$title" --body-file "$file" \
      --label release-blocker
end

Issue labels to create first (gh label create):

  • release-blocker — colour #d73a4a
  • critical — colour #b60205
  • major — colour #d93f0b