Jake
d7363cc913
The accumulator task was fire-and-forget — `tokio::spawn` without
retaining the JoinHandle. `stop_native_capture` sent a stop signal,
slept 50ms, and returned; the worker could still be running its
final flush and appending to `all_samples` when the next
`start_native_capture` cleared it. Rapid start→stop→start could
leak tail samples from one session into another.
Replace `NativeCaptureState.stop_tx` with `worker:
AsyncMutex<Option<CaptureWorker>>`, where CaptureWorker owns both
the stop sender and the spawned task's JoinHandle. New helper
`stop_worker(worker)` sends stop, drops the sender, and `.await`s
the join. Both the prior-worker tear-down in `start_native_capture`
and `stop_native_capture` itself go through the helper, so the
worker is always fully terminated before any downstream read or
next-session cleanup.
AsyncMutex (not std::sync::Mutex) because the stop path awaits
while holding the lock. Also drops the 50ms sleep from
stop_native_capture — the join is an exact barrier.
Two regression tests:
- stop_worker_awaits_full_termination_no_writes_after_join:
synthetic worker with an atomic counter and a flush marker.
After stop_worker the flush must have run and no further
writes may appear.
- stop_worker_is_idempotent_on_a_worker_that_has_already_exited:
tasks that stop themselves must still join cleanly.
A full cpal-backed start→stop→start integration test is not
feasible in Linux CI without an audio device. The component tests
cover the invariant the real flow depends on.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
70 lines
4.4 KiB
Markdown
70 lines
4.4 KiB
Markdown
---
|
|
name: Release-blockers index
|
|
description: Open issues that must land before v0.1 ships, derived from the 2026-04-22 code review
|
|
type: index
|
|
tags: [issues, release-blockers]
|
|
---
|
|
|
|
# Release-blockers
|
|
|
|
Issues here must land before Kon v0.1 ships. Each is sourced from
|
|
`docs/code-review-2026-04-22.md`. When `gh` CLI is available, these
|
|
should be mirrored as real GitHub issues on `jakejars/kon`.
|
|
|
|
## CRITICAL (2 open, 1 resolved)
|
|
|
|
| # | File | Area | Fix scope |
|
|
|---|---|---|---|
|
|
| RB-01 | [c1-live-session-race.md](c1-live-session-race.md) | `src-tauri/commands/live.rs` | large |
|
|
| RB-03 | [c4-transcript-profile-fk.md](c4-transcript-profile-fk.md) | `crates/storage/migrations.rs` + `database.rs` | large |
|
|
|
|
## MAJOR (5 open, 4 resolved)
|
|
|
|
| # | File | Area | Fix scope |
|
|
|---|---|---|---|
|
|
| RB-04 | [run-live-session-monolith.md](run-live-session-monolith.md) | `src-tauri/commands/live.rs` | large |
|
|
| RB-05 | [poll-inference-channel-fatality.md](poll-inference-channel-fatality.md) | `src-tauri/commands/live.rs` | medium |
|
|
| RB-08 | [power-assertion-macos-objc2.md](power-assertion-macos-objc2.md) | `src-tauri/commands/power.rs` | medium |
|
|
| RB-10 | [llm-prompt-preflight.md](llm-prompt-preflight.md) | `crates/llm/lib.rs` | medium |
|
|
| RB-11 | [keystore-thread-safety.md](keystore-thread-safety.md) | `crates/cloud-providers/keystore.rs` | medium |
|
|
|
|
## Resolved
|
|
|
|
| # | File | Area | Resolution |
|
|
|---|---|---|---|
|
|
| RB-02 | [c3-migrations-atomicity.md](c3-migrations-atomicity.md) | `crates/storage/migrations.rs` | Each migration now runs inside a `pool.begin()` / `tx.commit()` transaction alongside its `schema_version` insert. Regression test injects a poisoned v9 migration and asserts neither the partial schema change nor the version row persists. DRY'd `run_migrations_up_to` test helper onto the same code path. |
|
|
| RB-06 | [native-capture-worker-join.md](native-capture-worker-join.md) | `src-tauri/commands/audio.rs` | `NativeCaptureState.stop_tx` replaced by `worker: AsyncMutex<Option<CaptureWorker>>`. `CaptureWorker` bundles the stop sender and the spawned task's `JoinHandle`; `stop_worker(worker)` sends stop then `await`s termination. Both `start_native_capture` (prior-worker stop) and `stop_native_capture` use the helper. Removed the 50ms sleep — the join barrier is exact. Two regression tests cover the lifecycle guarantee and the already-exited case. |
|
|
| RB-07 | [runtime-capabilities-accelerators.md](runtime-capabilities-accelerators.md) | `src-tauri/commands/models.rs` | Introduced `compose_accelerators(whisper_enabled, loader_available, target)` as a pure helper; `supported_accelerators()` reads `cfg(feature = "whisper")`, `vulkan_loader_available()`, and target OS then delegates. `get_runtime_capabilities` uses it in place of the hard-coded `["cpu", "vulkan"]`. Whisper's `supports_gpu` now follows the feature flag. Five regression tests cover all permutations. |
|
|
| RB-09 | [decoder-partial-audio-on-error.md](decoder-partial-audio-on-error.md) | `crates/audio/decode.rs` | Packet-loop now propagates all non-EOF `SymphoniaError`s as `AudioDecodeFailed`; per-packet decode errors bubble via `?`. Mock-`MediaSource` regression test confirms mid-stream I/O errors surface instead of returning partial audio. |
|
|
| RB-12 | [hotkey-linux-device-filter.md](hotkey-linux-device-filter.md) | `crates/hotkey/linux.rs` | Extracted `device_supports_combo` helper; `try_attach_device` now reads the configured `HotkeyCombo` from the watch channel and checks support for that trigger key. Four regression tests land in `linux::tests`. |
|
|
|
|
## Dependencies
|
|
|
|
```
|
|
RB-01 (live session race)
|
|
└── blocked by RB-04 (run_live_session monolith refactor)
|
|
|
|
RB-03 (transcript-profile FK)
|
|
└── coupled with RB-02 (migrations atomicity)
|
|
— a v9 migration adding the FK constraint must be transactional
|
|
```
|
|
|
|
## How to convert to GitHub issues
|
|
|
|
Once `gh` CLI is installed and authed (`sudo dnf install -y gh && gh auth login`):
|
|
|
|
```fish
|
|
for file in docs/issues/rb-*.md c1-*.md c3-*.md c4-*.md run-*.md poll-*.md \
|
|
native-*.md runtime-*.md power-*.md decoder-*.md llm-*.md \
|
|
keystore-*.md hotkey-*.md
|
|
set -l title (head -1 "$file" | sed 's/^# //')
|
|
gh issue create --repo jakejars/kon --title "$title" --body-file "$file" \
|
|
--label release-blocker
|
|
end
|
|
```
|
|
|
|
Issue labels to create first (`gh label create`):
|
|
- `release-blocker` — colour `#d73a4a`
|
|
- `critical` — colour `#b60205`
|
|
- `major` — colour `#d93f0b`
|