Both whisper-rs-sys and llama-cpp-sys-2 run bindgen at build time,
which requires libclang.so/dylib/dll resolvable from the loader.
None of the three GitHub runners ship this out of the box today:
- ubuntu-22.04: bindgen-0.72.1 panics with 'couldn't find any
valid shared libraries matching libclang.so*'
- macos-latest: same panic against libclang.dylib
- windows-latest: choco already installed llvm here, but libclang
was on an unset LIBCLANG_PATH, so bindgen still couldn't find it
And llama-cpp-sys-2's vulkan feature (wired on by whisper-rs' vulkan
feature → whisper-rs-sys + its own shared ggml build) hard-panics on
Windows when VULKAN_SDK is unset, and needs libvulkan.so linkable on
Linux.
Changes, applied symmetrically to check.yml and build.yml:
- Linux: add libclang-dev, clang, libvulkan-dev to apt-get install.
- macOS: brew install llvm, set LIBCLANG_PATH to brew --prefix
llvm /lib so bindgen can load libclang.dylib.
- Windows: choco install vulkan-sdk, set VULKAN_SDK to the
newest-version directory under C:\VulkanSDK (resolved
dynamically so a minor-version bump doesn't hardcode-break
anything), set LIBCLANG_PATH to the llvm bin dir.
Unblocks the per-push cargo check job on main, phase4-systems-f7d0,
and phase4-ux-f7d0; also unblocks the release build. The Windows
Vulkan SDK install is the new long pole (~2 min on a cold runner)
but is needed unconditionally while the vulkan feature is on in
crates/transcription/Cargo.toml.
Co-authored-by: jars <jakejars@users.noreply.github.com>
135 lines
5.0 KiB
YAML
135 lines
5.0 KiB
YAML
# Per-push fast feedback: cargo check on Linux + Windows + macOS, plus
|
|
# the Svelte build. Catches platform-specific compile errors (the M3
|
|
# fix that broke on Windows because std::sync::mpsc::TryRecvError lives
|
|
# in a different module on certain configurations, etc) without paying
|
|
# the cost of the full Tauri release build.
|
|
#
|
|
# For the full installer build (.msi, .dmg, .AppImage) see build.yml.
|
|
name: check
|
|
|
|
on:
|
|
push:
|
|
branches: [main]
|
|
pull_request:
|
|
workflow_dispatch:
|
|
|
|
# Cancel any earlier in-progress runs for the same branch — a fresh push
|
|
# supersedes the previous one.
|
|
concurrency:
|
|
group: check-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
rust:
|
|
name: cargo check (${{ matrix.os }})
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
os: [ubuntu-22.04, windows-latest, macos-latest]
|
|
runs-on: ${{ matrix.os }}
|
|
timeout-minutes: 30
|
|
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
# System packages whisper-rs-sys + llama-cpp-sys-2 + Tauri need on each OS.
|
|
# - libclang-dev: bindgen (pulled by whisper-rs-sys + llama-cpp-sys-2)
|
|
# needs a libclang shared library at build time.
|
|
# - libvulkan-dev: llama-cpp-sys-2's `vulkan` feature links against
|
|
# libvulkan.so at build time, even when VULKAN_SDK is unset
|
|
# (falls back to the system-provided lib on Linux).
|
|
# - Linux is the heaviest because we depend on GTK/WebKit, audio,
|
|
# evdev, plus cmake for whisper.cpp.
|
|
- name: Install Linux deps
|
|
if: matrix.os == 'ubuntu-22.04'
|
|
run: |
|
|
sudo apt-get update
|
|
sudo apt-get install -y --no-install-recommends \
|
|
libwebkit2gtk-4.1-dev \
|
|
libappindicator3-dev \
|
|
librsvg2-dev \
|
|
libasound2-dev \
|
|
libudev-dev \
|
|
patchelf \
|
|
cmake \
|
|
build-essential \
|
|
libclang-dev \
|
|
clang \
|
|
libvulkan-dev
|
|
|
|
# macOS: cmake is preinstalled in macos-latest but pin via brew to
|
|
# be explicit and future-proof. Xcode CLT provides libclang but the
|
|
# runner's default clang install does not ship libclang.dylib — use
|
|
# Homebrew's LLVM, which does, and point LIBCLANG_PATH at it.
|
|
- name: Install macOS deps
|
|
if: matrix.os == 'macos-latest'
|
|
run: |
|
|
brew list cmake >/dev/null 2>&1 || brew install cmake
|
|
brew list llvm >/dev/null 2>&1 || brew install llvm
|
|
# Expose libclang.dylib to bindgen for subsequent steps.
|
|
echo "LIBCLANG_PATH=$(brew --prefix llvm)/lib" >> "$GITHUB_ENV"
|
|
|
|
# Windows: cmake + clang (for whisper-rs-sys/llama-cpp-sys bindgen)
|
|
# + Vulkan SDK (required by llama-cpp-sys-2 when the `vulkan`
|
|
# feature is on — it hard-panics on a missing VULKAN_SDK env var).
|
|
#
|
|
# choco's `vulkan-sdk` package installs into
|
|
# C:\VulkanSDK\<version>\; the canonical VULKAN_SDK path is that
|
|
# directory. We resolve it dynamically so a minor-version bump in
|
|
# the SDK doesn't hardcode-break this step.
|
|
- name: Install Windows deps
|
|
if: matrix.os == 'windows-latest'
|
|
shell: pwsh
|
|
run: |
|
|
cmake --version
|
|
choco install -y llvm --no-progress
|
|
choco install -y vulkan-sdk --no-progress
|
|
$sdkRoot = Get-ChildItem -Directory "C:\VulkanSDK" | Sort-Object Name -Descending | Select-Object -First 1
|
|
if (-not $sdkRoot) {
|
|
Write-Error "VulkanSDK directory not found under C:\VulkanSDK after choco install"
|
|
exit 1
|
|
}
|
|
echo "VULKAN_SDK=$($sdkRoot.FullName)" >> $env:GITHUB_ENV
|
|
echo "LIBCLANG_PATH=C:\Program Files\LLVM\bin" >> $env:GITHUB_ENV
|
|
|
|
- name: Install Rust toolchain
|
|
uses: dtolnay/rust-toolchain@stable
|
|
|
|
# Cache the Cargo target dir + registry per OS so the heavy
|
|
# whisper-rs-sys C++ build only happens on a clean cache.
|
|
# The workspace root is the repo root (see //Cargo.toml), so target/
|
|
# lives at ./target — NOT src-tauri/target. Pointing the cache at
|
|
# src-tauri/target produced silent cache misses on every run and was
|
|
# the real reason Windows check times felt like they compiled sqlx
|
|
# from scratch every time. Use the repo root as the workspace hint.
|
|
- name: Cache Rust artifacts
|
|
uses: Swatinem/rust-cache@v2
|
|
with:
|
|
workspaces: .
|
|
shared-key: kon-${{ matrix.os }}
|
|
|
|
- name: cargo check (workspace)
|
|
run: cargo check --workspace --all-targets
|
|
|
|
frontend:
|
|
name: svelte build + lint
|
|
runs-on: ubuntu-22.04
|
|
timeout-minutes: 15
|
|
steps:
|
|
- uses: actions/checkout@v4
|
|
|
|
- name: Install Node
|
|
uses: actions/setup-node@v4
|
|
with:
|
|
node-version: 20
|
|
cache: npm
|
|
|
|
- name: Install JS deps
|
|
run: npm ci
|
|
|
|
# `tauri build` inside check.yml would trigger the full Rust build
|
|
# which is owned by the rust job. Here we only validate that the
|
|
# Svelte/Vite frontend compiles cleanly.
|
|
- name: Build frontend (Vite only)
|
|
run: npm run build
|